Recommendations should enable the supply of a rationale or rule as a descriptor to aid an operator in particular.
Many of these attributes (e.g. Algorithm Type) are not naturally Quantities
Descriptor or Quantifier would be better classifiers for the type
It is possible to recommend a status, but unclear how to quantify that status.
Add an Optional Quantifier to the Status Recommendation
Add an optional quantifier parameter the recommendStatus operation of the ExtendedCategorization interface
Figure 10.33 PlanExecutionInformation Service Mapping (Component diagram) is in the PlanExecutionRecommendation (10.5) section, but relates to PlanExecutionInformation (10.4) section
Move PlanExecutionInformation Service Mapping diagram
Move the PlanExecutionInformation Service Mapping (Component diagram) - Figure 10.33 - from section 10.5 to section 10.4
The latest reference for GraphQL is
GraphQL Foundation (https://graphql.org/foundation/),
online at https://spec.graphql.org/October2021/
Update GraphQL Reference
Update the GraphQL reference to the latest.
In v1.1 of TEX in the DDS-IDL PSM all the packages are mapped into the org::omg::tex namespace. TEX was adopted by the DTC at the 2023 Q3 meeting and should be expected to be published/issued ahead of TDAI v1.0.
TDAI current targets v1.0 which does not have this enclosing namespace.
It would make sense to target v1.1 and also to use an equivalent enclosing namespace for consistency.
This issue relates to an AB review comment.
Target TEX v1.1 and use an enclosing namespace
TDAI v1.0 should target TEX v1.1 (i.e. be the normative reference).
Each of the IDL files for the DDS PSM should have an enclosing namespace of org::omg::tdai
The DDS IDL files should reference identifiers using the relevant enclosing namespace - org::omg::tex (for top-level packages defined by TEX) or org::omg::tdai (for top-level packages defined by TDAI).
It is not totally clear how an implementer uses (invokes, implements) a PIM method within the DDS/IDL PSM.
Add Comments to Topic Type Definition to emphasise their role
Add comments to each generated topic type from a method signature (as per section 12.1) to state that it is intended as a DDS Topic type, maps to the original PIM method and is used through publication to invoke or subscription to implement.
For each topic type insert (prepend) at the head of the comment block
"This is the DDS Topic type for invoking and implementing the {@Operation} method on the {@Interface} interface.
To invoke the operation publish a DDS Sample of this type; to implement it subscribe for samples."
Some diagrams no or little meaningful content have been generated into the specification. This add no value and the specification would be clearer without them.
Consider:
Remove Superfluous Diagrams
Remove diagrams and captions for 10.40 & 10.43 (original numbering) and renumber remaining figures
Use tdai rather than tda to be consistent with nomenclature.
Change response prefex to tdai
Change prefix for standard response to tdai
Spec users have not understood that EntityRef values correspond to Entities received over the TEX interface
Clarify relationship to TEX in the overview section
Extend the opening paragraph to discuss the linkage to the TEX specification and explicitly mention EntityRef.
@key should be lower case (not title case @Key)
Change Key Annotation to Lower Case
Change @Key to @key in the DDS/IDL PSM (impacted files attached).
The GraphQL in describing the extensible enumeration mapping copies the DDS text and hence refers to the IDL: type system. It should refer to the GraphQL type system.
Refer to GraphQL Object types
State that by default PIM classes are mapped to GraphQL object and input object types.
State that the base type for inheritance is an object type (and input equivalent).
For Extensible Enumerations they are mapped to object and input object types not structs.
Tactical Decision Aids may have a revised opinion about previous decisions. This may mean lower confidence in a previous recommendation rather than an alternative recommendation (which would override). There needs to be a mechanism to unset, or recommend that the system reverts to the previous state.
Add Cancel Recommendation and Null Descriptor
Two additional mechanisms are proposed for different circumstances.
Firstly a Cancel Recommendation operation, which cancels the effect of the recommendation with the same request id. Not all recommendations will always be capable of being cancelled by the service implementor. For implementation compatibility purposes a 'can be cancelled' attribute is added to the response. As with referrals, additional responses are allowed for changes of state, so cancellation may become impossible later and, if so, the service provider sends an additional response to that effect.
Secondly a Null Descriptor should be defined, for categorization recommendations in particular, this recommends return to a state as if the Decision Aid has never made any recommendations for that entity
When making a recommendation of status for an entity, for some concepts it is important to be able to do this by reference to some other entity. E.g. when saying that an entity is a threat to identify the entity that is threatened.
Add Optional Entity Parameter to Recommend Status Operation
By adding an optional referenceEntity parameter to the recommendStatus operation it will be possible to assert a status with respect to another entity. E.g. rendezvous, refuel or threat
E.g. for a timeout
Add additional standard error conditions
Add standard error conditions for a timeout and a general internal error. Also state that standard descriptors may be extended for implementation specifics.
In the GraphQL Data Model PSM section the text refers to DDS rather than GraphQL
Refer to GraphQL schema rather than DDS PSM IDL
In the GraphQL PSM sections the code generation should be described as transforming to GraphQL schema
DDS X-Types requires attributes at each level of a nested key type to have the @key annotation.
Add Additional Key Annotations at Intermediate Levels
Add annotations at each level in the type structure as per the DDS XTYPES specification. The attached files are those that are impacted.
Some decision aids have a need to qualify a status recommendation with a reference entity - e.g. that an entity is a threat to another entity in particular.
This is a duplicate of the next issue
Looks like this issue was raised twice in error
TDAI provides methods to change standard identity, classification and activity individually. Some decision aids will want to recommend changes to more than one of these at once as a coherent set.
Define a Recommend Categorization operation
Add a new operation recommendCategorization to the extendedCategorization interface, which allows definition of a superset of the categorization recommendation as a single atomic recommendation. This consists optional classification, identity, activity and a list of status values.
