SBVR 1.0b2 FTF Avatar
  1. OMG Issue

SBVR — Annex E - editorial issues

  • Key: SBVR-81
  • Legacy Issue Number: 9874
  • Status: closed  
  • Source: General Electric ( Mark Linehan)
  • Summary:

    E.1.4 example 2 and also the 2nd rule in E.2.2.2.7 use " rental has duration"

    The correct fact type at E.2.2.1.5 is "rental has rental duration". Probably E.2.2.1.5 should be changed, plus the reference in E.2.2.2.3.

    E.1.4 example 3 and numerous other places use "rental has driver".

    The fact type "rental has driver" seems to be missing entirely, though cited at E.1.4 and elsewhere. Suggest adding it to E.2.2.1.11.

    This also affects rules (e.g. in E.2.2.4) that depend upon "rental has primary driver" and "rental has additional driver".

    And it affects E2.2.2.10 rule 4 that depends upon "rental has additional driver".

    E.1.4 example 4 and several other places use "branch has drop-off location"

    E.2.2.1.9 has "rental uses drop-off location". Maybe it should be marked as an "is-part-of fact type" or given a synonym "branch has drop-off location"

    E.1.4 example 5 and several other places use "rental has rental charge"

    "rental charge" is given in E.2.2.1.7 but not "rental has rental charge"

    E.1.4 example 6 and E.2.2.2.3 rule 1 use "rental has estimated rental charge"

    "estimated rental charge" is given in E.2.2.1.7 but not "rental has estimated rental charge"

    Also, these two rules elide "of a rental" from "... an estimated rental charge [of a rental] is provisionally charged ...." Maybe that's ok since there is no
    other kind of estimated rental charge, but if so the spec should say that somewhere.

    E.1.4 example 6 and several other places use "rental has renter"

    "rental has renter" presumably belongs in E.2.2.1.11
    E.1.4 example 7 uses "branch is included in local area"

    Question: "branch is included in local area" is a partitive fact type. Is that what makes "local area of branch" a legitimate usage?

    E.1.4 example 7 uses "rental has rented car"

    "rental has rented car" is missing from the list of Supporting Fact types, but see below about it.

    E.1.4 examples 7 & 8 and various other places use "rental has rented car"

    "rental has rented car" presumably belongs in E.2.2.1.5, but according to figure E-7 it is the renter, not the rental, that has the rented card

    E.2.2.2.2 rule 2 uses "rental has rental period"

    "rental has rental period" presumably belongs in E.2.2.1.5, maybe as a synonymous form of "rental includes rental period "

    E.2.2.2.3 rule 4 and elsewhere use "cash rental has lowest rental price"

    "cash rental has lowest rental price" presumably belongs in E.2.2.1.7, maybe as a synonymous form of "cash rental honors lowest rental price"

    Also, this fact type is not listed in "Supported Fact Types".

    E.2.2.2.3 rule 6 uses "rental has car group"

    the correct fact type is "rental has requested car group"

    E,2.2.2.5 rule 1 uses "rented car" in the rule but "local area owns rental car" in the Supporting Fact Types.

    E.2.2.2.8 rule 1 uses "rental car has scheduled service"
    ... which probably belongs in E.2.2.1.10

    E.2.2.2.14 rule 1 uses "rental has base rental price"
    ... which probably belongs in E.2.2.1.7

    E.2.2.2.15 rule 1 uses "operating company has insurer"

    "insurer" appears in Figure E.5 but is not defined anywhere, much less "operating company has insurer". Both belong in E.2.2.1.3.

  • Reported: SBVR 1.0b1 — Tue, 27 Jun 2006 04:00 GMT
  • Disposition: Resolved — SBVR 1.0b2
  • Disposition Summary:

    E.1.4 example 2 and also the 2nd rule in E.2.2.2.7 use " rental has duration"
    The correct fact type at E.2.2.1.5 is "rental has rental duration". Probably E.2.2.1.5 should be changed, plus the reference in E.2.2.2.3.
    corrected in Issues 9449 and 9450
    E.1.4 example 3 and numerous other places use "rental has driver".
    The fact type "rental has driver" seems to be missing entirely, though cited at E.1.4 and elsewhere. Suggest adding it to E.2.2.1.11.
    This also affects rules (e.g. in E.2.2.4) that depend upon "rental has primary driver" and "rental has additional driver".
    And it affects E2.2.2.10 rule 4 that depends upon "rental has additional driver".
    corrected in Issues 9449 and 9450
    E.1.4 example 4 and several other places use "branch has drop-off location"
    E.2.2.1.9 has "rental uses drop-off location". Maybe it should be marked as an "is-part-of fact type" or given a synonym "branch has drop-off location"
    corrected in Issue 9449
    E.1.4 example 5 and several other places use "rental has rental charge"
    "rental charge" is given in E.2.2.1.7 but not "rental has rental charge"
    corrected in Issue 9449
    E.1.4 example 6 and E.2.2.2.3 rule 1 use "rental has estimated rental charge"
    "estimated rental charge" is given in E.2.2.1.7 but not "rental has estimated rental charge"
    Because 'estimated rental charge' is a kind of 'rental charge' it is valid to use the verb from the fact type that reflects the more general concept.
    Also, these two rules elide "of a rental" from "... an estimated rental charge [of a rental] is provisionally charged ...." Maybe that's ok since there is no
    other kind of estimated rental charge, but if so the spec should say that somewhere.
    The fact type 'estimated rental charge is provisionally charged to credit card' is part of the vocabulary.
    E.1.4 example 6 and several other places use "rental has renter"
    "rental has renter" presumably belongs in E.2.2.1.11
    corrected in Issue 9449
    E.1.4 example 7 uses "branch is included in local area"
    Question: "branch is included in local area" is a partitive fact type. Is that what makes "local area of branch" a legitimate usage?
    corrected in Issue 9449
    E.1.4 example 7 uses "rental has rented car"
    "rental has rented car" is missing from the list of Supporting Fact types, but see below about it.
    E.1.4 examples 7 & 8 and various other places use "rental has rented car"
    "rental has rented car" presumably belongs in E.2.2.1.5, but according to figure E-7 it is the renter, not the rental, that has the rented card
    corrected in Issue 9449
    E.2.2.2.2 rule 2 uses "rental has rental period"
    "rental has rental period" presumably belongs in E.2.2.1.5, maybe as a synonymous form of "rental includes rental period "
    corrected in Issue 9449
    E.2.2.2.3 rule 4 and elsewhere use "cash rental has lowest rental price"
    "cash rental has lowest rental price" presumably belongs in E.2.2.1.7, maybe as a synonymous form of "cash rental honors lowest rental price"
    Also, this fact type is not listed in "Supported Fact Types".
    No change (beyond the scope of a simple fix, due to nature of the extended discussion in E.2.2.2.3 that this is part of). Defer to resolution in Issue 10628.
    E.2.2.2.3 rule 6 uses "rental has car group"
    the correct fact type is "rental has requested car group"
    corrected in Issue 9449
    E.2.2.2.5 rule 1 uses "rented car" in the rule but "local area owns rental car" in the Supporting Fact Types.
    Not a problem. ('rented car' is a role of 'rental car' in the situation of a rental. The ownership fact type is correctly shown using 'rental car'.)
    E.2.2.2.8 rule 1 uses "rental car has scheduled service"
    ... which probably belongs in E.2.2.1.10
    See below.
    E.2.2.2.14 rule 1 uses "rental has base rental price"
    ... which probably belongs in E.2.2.1.7
    See below.
    E.2.2.2.15 [actually, E.2.2.2.11.4] rule 1 uses "operating company has insurer"
    "insurer" appears in Figure E.5 but is not defined anywhere, much less "operating company has insurer". Both belong in E.2.2.1.3.
    See below.

  • Updated: Fri, 6 Mar 2015 20:58 GMT