SpacePython 1.2 requires 3.12, it should require it accordingly.
In pyproject.yaml, change 3.6 to 3.12
The package name of 'space' is already in use by another project on PyPI. A unique package name should be used
Several small edits were not included in previous updates.
Make small edits detailed in revised section.
See small changes in the revised section.
SpecificTime class should support providing a timezone and the waitUntil() function should support timezones that have a timezone.
Update SpacePython to support timezone being specified in SpecificTime class
SpecificTime should allow providing time strings that have a timezone.
waitUntil() function should respect the timezone of the field provided.
waitUntil() is also being updated to work with SpecificTime or the underlying timedate type.
Line 49: Change to:
t = datetime.datetime.now(tz)
Line 51: Change to:
t.second, t.microsecond, tz)
Line 56 (added after Line 55):
May optionally end with a timezone indicator, such as Z.
Lines 62-68 replaced with:
t = datetime.datetime.fromisoformat(strval)
Line 70 replaced with:
t.second, t.microsecond, t.tzinfo)
Line 186 replaced with:
def waitUntil(specificTime:datetime.datetime) -> None: #Normative
Line 192 replaced with:
Complete changes are in the attached patch file against the changes as a result of SOLM12-6.
... While doing this we think we’ve identified an omission in the mapping table.
If you look at the SOLM you’ll see this model for the Parameter. Note the highlighted aggregate object. If we go to the table for the mapping we see:
Parameter.value()
Parameter.raw()
Of course raw() doesn’t exist in the model, but there’s a description (note uncal doesn’t exist). But the but is there’s no mapping item to get the timestamp. However in the reference implementation in a section that should be normative there’s the report method that returns the time and the value (effectively a tuple that represents the InstantValue – see the 6.4.6 description).
In my book this should be a bug report to add a Parameter.report() that returns the InstantValue data as a tuple of value, timestamp. So can we report this as a bug?
Replace with sample() function
Replace SpacePython report() function with a new function sample() that returns a dictionary including the time, value, and raw values for a single sample. The change for this function is included in the work for issue #6.
The terms XTCE and GEMS should not be part of the SOLM meta models or functions that are projected from it (like SpacePython).
The specification should talk about Parameters that are being queried (possibly as Spacecraft or Ground Parameters), though the transport/method should be decoupled since there are multiple interfaces that could be used (direct integration with an end product, via GEMS, via SNMP, via a message bus/C2MS, or perhaps via a database).
Addressing references to the PSM of SpacePython at this time
The updated section of SpacePython (section 8) is being replaced with new content as part of issue #6. The updated version addresses this issue for the single PSM that remains as part of SOLM.
The user interface (operatorQuery) function is embedded in the middle of the SpacePython implementation and is not able to be separately implemented.
The method of prompting for a value may vary (such as for a web user interface versus a desktop application) and this variance is independence of the implementing provider for the SOLM language module.
Implementing as part of changes to issue #6
Issue #6 includes updates to the SpacePython library to allow for a pluggable interface for different implementations of the language. The plug-in can have different implementations for the UI and data backing.
SpacePython 1.1 requires that the reference implementation is modified/tailored by an implementing project/customer. As such, it does not have a loosely coupled implementation where the interface and implementation are separate.
Implementing as part of changes to issue #6
Issue #6 includes updates to the SpacePython library to allow for a pluggable interface for different implementations of the language.
The data model should harmonize spacecraft and ground assets and therefore the language model should simplify/make this consistent as much as possible.
Update to align with modern language
See changes in the Revised Text.
Patch file for this change is attached to this issue.
Within SpacePython times.py TimeInterval _str_() function, the following lines are faulty:
hours = seconds / 3600
minutes = (seconds % 3600) / 60
Both of these variables should be integers (not floating point values)
These instead should be:
hours = int(seconds / 3600)
minutes = int((seconds % 3600) / 60)
Update hours and minutes calculations
In times.py, change:
hours = seconds / 3600
To:
hours = int(seconds / 3600)
And:
minutes = (seconds % 3600) / 60
To:
minutes = int((seconds % 3600) / 60)
Section 6.7 represents compliance between the SOLM spec and the original RFP requirements. This likely should have been part of section 0 and removed during FTF. As such, this section should now be removed.
Remove section 6.7
Remove 6.7 in its entirety.
The Comet Control Language is a vendor-specific language that is not maintained by the SOLM RTF or any active member of the Space Domain Task Force. As such, it is unable to be maintained by the SOLM RTF maintainers. In addition, we do not see value in maintaining it due to lack of awareness of it being implemented/used in conjunction with SOLM.
Remove mentions of Comet Control Language
See Revised Text
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that allow determining the current status/flags of a parameter (including the severity) are not available in the language at this time.
Defer to future SpacePython version
Defer to future SpacePython version. Can be re-evaluated in the future.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that enabling the establishment and release of command locks are missing from the language.
Defer to future SpacePython version
Defer to future SpacePython version. Can be re-evaluated in the future.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that perform telemetry and limit checks are missing from the language at this time.
Defer to future SpacePython version
Defer to future SpacePython version. Can be re-evaluated in the future.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that allow retrieval of metadata from a previous directive/command that was issued do not exist in the language.
Defer to future SpacePython version
Defer to future SpacePython version. Can be re-evaluated in the future.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that create ground system events do not currently exist in the language.
Defer to future SpacePython version
Defer to future SpacePython version. Can be re-evaluated in the future.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that provide parameter and type information are lacking or insufficient in the language.
Defer to future SpacePython version
Can be re-evaulated in the future
operatorQuery allows for any number of inputs of any type to be provided. An implementation is very difficult to provide a friendly experience.
Would be valuable if guidance is provided for common usage patterns, including:
Defer to future SpacePython version
Existing OperatorQuery function only supports string parameter input (for zero or more strings). Consider extending the Query class to have additional methods for other usage patterns in the future.
SpacePython defines its own time object. It should instead utilize native time/date functionality. This would make procedures be easier to author and better integrate with existing and third-party libraries.
Native Python DateTime class does not support nanoseconds
The current custom class adds support for nanoseconds. It is an extended class on top of the native type though.
Deferring this issue to re-evaluate if Python gains improved time precision.
SpacePython defines its own time object. It should instead utilize native time/date functionality. This would make procedures be easier to author and better integrate with existing and third-party libraries.
operatorQuery allows for any number of inputs of any type to be provided. An implementation is very difficult to provide a friendly experience.
Would be valuable if guidance is provided for common usage patterns, including:
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that provide parameter and type information are lacking or insufficient in the language.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that allow retrieval of metadata from a previous directive/command that was issued do not exist in the language.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that create ground system events do not currently exist in the language.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that enabling the establishment and release of command locks are missing from the language.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that allow determining the current status/flags of a parameter (including the severity) are not available in the language at this time.
SpacePython is missing critical functions to be able to perform vital capability required for a real-time command and control system.
Functions that perform telemetry and limit checks are missing from the language at this time.
The SpacePython files should point to the copyright information within the SOLM specification itself rather than a single vendor.
Change copyright in files
Change the copyright to be based on the Object Management Group's SOLM specification
Within space/parameters.py, the ulong (an unsigned type) is mapped to an int (a signed type). Should be mapped to unsigned (an unsigned format).
Change ulong mapping to be "unsigned"
Within the typeNames assignment of space/parameters.py, change int to unsigned in:
'uint': unsigned, 'long': int, 'ulong': int,\
The comments in SetMomentumWheelSpeed.py state that the <module>._doc_ text corresponds to the Procedure.description attribute in the metamodel. This text should correspond the HeaderComment in the metamodel instead, and the Procedure.description should correspond to <module>.invoke._doc_
Change text within SetMomentumWheelSpeed.py
Change the text comment within SetMomentumWheelSpeed.py.
The terms XTCE and GEMS should not be part of the SOLM meta models or functions that are projected from it (like SpacePython).
The specification should talk about Parameters that are being queried (possibly as Spacecraft or Ground Parameters), though the transport/method should be decoupled since there are multiple interfaces that could be used (direct integration with an end product, via GEMS, via SNMP, via a message bus/C2MS, or perhaps via a database).
Defer to future minor revision version
Defer implementation until future revision
... While doing this we think we’ve identified an omission in the mapping table.
If you look at the SOLM you’ll see this model for the Parameter. Note the highlighted aggregate object. If we go to the table for the mapping we see:
Parameter.value()
Parameter.raw()
Of course raw() doesn’t exist in the model, but there’s a description (note uncal doesn’t exist). But the but is there’s no mapping item to get the timestamp. However in the reference implementation in a section that should be normative there’s the report method that returns the time and the value (effectively a tuple that represents the InstantValue – see the 6.4.6 description).
In my book this should be a bug report to add a Parameter.report() that returns the InstantValue data as a tuple of value, timestamp. So can we report this as a bug?
Defer to future minor revision version
Defer to future revision.
SpacePython is not compatible with Python version 3. Multiple script errors are encountered. Python version 2 is no longer supported, so software should be updated to work with later version.
Update reference of Python 2.6 and deliver Python3 version of SpacePython files
Within spec document, update references of Python 2.6 to Python 3.
Apply changes to Python files to incorporate changes to make it work under Python3. These changes were performed using Git and a patch file is provided of the changes.
The title of the spec as well as the introduction of it (section 1.1...) make the reader think that this spec is about all known and future spacecrafts while it's about Earth Satellites as proved by, e.g., the use of UTC time.
The introduciton needs clearly to state this and the name of the spec should be changed - earth Satellite Operations Language Metamodel (eSOLM)? -.
Rename Spacecraft Operations Language Metamodel to Satellite Operations
Language Metamodel. Occurrences corrected on Title page, document footer,
and Glossary (p 4).
On page 1 introduction replace first paragraph:
This specification defines a meta-model, Spacecraft Operations Language Meta-model (SOLM), for
representing spacecraft operations procedures. These procedures contain sequences of instructions to
conduct spacecraft operations, typically consisting of spacecraft commands and spacecraft telemetry
comparisons. These procedures may also include the configuration of ground equipment, configuration of
spacecraft test equipment, execution of ground testing, and execution of on-orbit testing. Historically, these
procedures have been captured in flowcharts, text manuals, and a number of different scripting languages
used for ground station automation. A standard meta-model to represent spacecraft operations procedures
will facilitate the transfer of procedures between the spacecraft vendor and the spacecraft operator, as well
as allow for maintenance and transfer of the procedures across different ground systems employed over the
lifetime of the spacecraft.
With:
This specification defines a meta-model, Satellite Operations Language Meta-model (SOLM), for
representing spacecraft operations procedures. These procedures contain sequences of instructions to
conduct spacecraft operations, typically consisting of spacecraft commands and spacecraft telemetry
comparisons. These procedures may also include the configuration of ground equipment, configuration of
spacecraft test equipment, execution of ground testing, and execution of on-orbit testing. Historically, these
procedures have been captured in flowcharts, text manuals, and a number of different scripting languages
used for ground station automation. A standard meta-model to represent spacecraft operations procedures
will facilitate the transfer of procedures between the spacecraft vendor and the spacecraft operator, as well
as allow for maintenance and transfer of the procedures across different ground systems employed over the
lifetime of the spacecraft.
This specification is primarily aimed at providing procedure portability for earth-orbiting satellites. While
deep-space spacecraft use similar operational procedures, they also use extensive on-board procedures and
there are significant considerations in the representation of time that are not incorporated in this metamodel.
The SpacePython mapping is too vague to insure compatible implementations, and the example python script in the document will not cut-and-paste as a valid script. Please provide all example scripts as machine-consumable files and expand the SpacePython example to cover all of the SOLM features or add additional examples to cover the features
Added two additional SpacePython script examples to cover the Python extensions required by
SOLM. Created an installable Python package that contains the script examples and enough
skeleton implementation to run the scripts on any Python-compatible platform. Also created a
package with the equivalent CCL scripts in machine-consumable form. Regress the Python
version compatibility requirement to 2.6 to allow working with current enterprise Linux releases.
The classifier - Time - for WaitOnExpression.timeout and WaitOnTime.time were not set correctly (usually if the classifier is typed into the field)..
This resolution applies to the non-normative model as captured in Enterprise Architect and results
in changes to the normative XMI model when it is exported. The “revised text” below shows the
impact on the XMI model. Figures 5 and 6 are generated from the non-normative model and
required updating for consistent use of the TimeInterval and SpecificTime classifiers. A document
search also found that section 6 contained two references to an older non-existent classifier
name (RelativeTime) instead of the TimeInterval classifier in the normative metamodel.
SpecificTime.dayOfYear() returns a void - change to Integer per the other methods
This resolution applies to the non-normative model as captured in Enterprise Architect and results
in changes to the normative XMI model when it is exported. The “revised text” below illustrates
the impact on the XMI model. There is also a change in Figure 11 for the method signature.
The model makes use of a 'UML' Code product type - if you set the Language for each class to '<none>' you not only get the same PrimitiveTypes, but the XMI exporter will produce the correct hrefs in the XMI to those DataTypes defined in UML
This resolution applies to the language selection in the non-normative model as
captured in Enterprise Architect and results in changes to the normative XMI
model when it is exported. The “revised text” below illustrates the impact on the
XMI model, but does not identify every line changed, since the XMI is machine
generated.
Model should be exported in latest available XMI (2.4.1 is current)
The original XMI file in the specification was exported in XMI 1.4 from the model in Enterprise
Architect. This file is replaced with a current export after all other modeling changes have been
applied.
Procedure.duration is typed by an unknown tyoe - RelativeTime. Reset this type to TimeInterval
This resolution applies to the non-normative model as captured in Enterprise Architect and results
in changes to the normative XMI model when it is exported. The “revised text” below shows the
impact on the XMI model.