Finite State Machine Component for RTC Avatar
  1. OMG Specification

Finite State Machine Component for RTC — All Issues

  • Acronym: FSM4RTC
  • Issues Count: 14
  • Description: All Issues
Open Closed All
All Issues

Issues Summary

Key Issue Reported Fixed Disposition Status
FSMCFRFF-20 The 'type' column should be added to property tables FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-10 In Figure 7.21, sequence diagram should be used instead of activity diagram FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-26 ExtendedFsmService::get_fsm_structure returns a wrong type FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-1 XMI file robotics/2014-09-04 there are copies of packages SDOPackage and PrimitiveTypes rather than references FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-12 In Figure 7.23 and Figure 7.25, sequence diagrams don't contain alternative combination fragment FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-11 In Section 7.2.6.3, descriptions are omitted for some properties FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-4 In Figure 7.3, relationship among elements are unclear FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-6 In Figure 7.9 and Figure 7.14, the sequence diagram does not show some timing information FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-9 In Section 7.2.6.2, the behavior of 'overwrite' for 'dataport.write.buffer.full_policy' is not explained FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-7 In Section 7.2.5.3, the direction of fsm_structure argument of ExtendedFsmService::get_fsm_structure method should be 'out' rather than 'inout' FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-5 In Section 7.2.4.2, detail descriptions for each element of the table of hints are required FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-8 In Section 7.2.6, PSM representations such as 'CORBA::RepositoryID' are used in the PIM FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-2 In Figure 7.1, RTC::FSM interface is used but it is not defined in the RTC spcefification FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed
FSMCFRFF-3 In Figure 7.2, relationship among FsmComponent, ComponentObserver, ExtendedFsmService and DataPort is unclear FSM4RTC 1.0b1 FSM4RTC 1.0 Resolved closed

Issues Descriptions

The 'type' column should be added to property tables

  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    Lots of property tables in the specification have name, value and description columns. However the type of values are undefined. To clear the definition of the type of each value, the 'type' column should be added to property tables.

  • Reported: FSM4RTC 1.0b1 — Thu, 6 Aug 2015 11:38 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Added type column to property tables

    According to the beta specification, the type of a property is not defined and it prevents implementing the specification. To show the type of a property clearly, the type column has been added to property tables.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-20.docx 1.12 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Figure 7.21, sequence diagram should be used instead of activity diagram

  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    A sequence diagram with alternative combination fragments will describe the workflow in the Figure 7.21 more clearly.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 18:45 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Replace the activity diagram of Figure 7.21 with a sequence diagram

    To show the connect operation clearer, the activity diagram is replaced with a sequence diagram.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:

ExtendedFsmService::get_fsm_structure returns a wrong type

  • Status: closed   Implementation work Blocked
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In ExtendedFsmService.idl, ExtendedFsmService::get_fsm_structure returns FsmStructure. However, according to the specification, ExtendedFsmService::get_fsm_structure shall return ReturnCode_t.

  • Reported: FSM4RTC 1.0b1 — Tue, 18 Aug 2015 11:30 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Fix the return type of ExtendedFsmService::get_fsm_structure

    Changed the return type of ExtendedFsmService::get_fsm_structure from FsmStructure to ReturnCode_t.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-26.docx 1.11 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

XMI file robotics/2014-09-04 there are copies of packages SDOPackage and PrimitiveTypes rather than references

  • Key: FSMCFRFF-1
  • Legacy Issue Number: 19611
  • Status: closed  
  • Source: agnos.ai UK Ltd ( Pete Rivett)
  • Summary:

    In the XMI file robotics/2014-09-04 there are copies of packages SDOPackage and PrimitiveTypes rather than references (via href) to the OMG standard URLs for these

    A primitive type “void” is used instead of the operation having no return parameter.

  • Reported: FSM4RTC 1.0b1 — Thu, 18 Sep 2014 04:00 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Fix copies of types in XMI file robotics/2014-09-04

    Copies of packages RTC, SDOPackage and PrimitiveTypes in XMI file robotics/2014-09-04 have been replaced with references.

  • Updated: Tue, 22 Dec 2015 15:06 GMT

In Figure 7.23 and Figure 7.25, sequence diagrams don't contain alternative combination fragment

  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Figure 7.23 and Figure 7.25, sequence diagrams should show phases of communication between ports such as 'connect' with alternative combination fragments.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 18:52 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Add alternative sections to sequence diagrams in Figure 7.23 and 7.25

    To show each phase such as connection clearer, alternative sections has been added to sequence diagram in Figure 7.23 and Figure 7.25.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:

In Section 7.2.6.3, descriptions are omitted for some properties

  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Section 7.2.6.3, descriptions are omitted for some properties.
    This must be fixed.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 18:49 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Omitted descriptions in Section 7.2.6.3 have been added

    Omitted descriptions of tables to explain the meaning of properties in Section 7.2.6.3 has been added.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-11.docx 1.12 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Figure 7.3, relationship among elements are unclear

  • Key: FSMCFRFF-4
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Figure 7.3, references from the RTC specification are required to show the relationship among elements.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:31 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Update Figure 7.3

    To show relationship with FSM4RTC and RTC clearer, name spaces and boundaries have been added to Figure 7.3.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:

In Figure 7.9 and Figure 7.14, the sequence diagram does not show some timing information

  • Key: FSMCFRFF-6
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Figure 7.9 and Figure 7.14, the sequence diagram does not show:

    • the timing when RTObject calls update_status
    • the timing when Tool calls remove_service
    • the timing when ComponentObserver is destroyed.
  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:46 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Add timing information to Figure 7.9 and Figure 7.14

    To show timing information clearer, opt fragments are added to sequence diagrams in Figure 7.9 and Figure 7.14.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:

In Section 7.2.6.2, the behavior of 'overwrite' for 'dataport.write.buffer.full_policy' is not explained

  • Key: FSMCFRFF-9
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    The specification have to explain what is overwritten (ex. the last data) if the 'dataport.write.buffer.full_policy' is 'overwrite'.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 18:38 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    The explanation for the overwrite policy of 'dataport.write.buffer.full_policy' has been added

    The explanation has been added to the each overwrite policy.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-9.docx 1.11 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Section 7.2.5.3, the direction of fsm_structure argument of ExtendedFsmService::get_fsm_structure method should be 'out' rather than 'inout'

  • Key: FSMCFRFF-7
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Section 7.2.5.3, the direction of fsm_structure argument of ExtendedFsmService::get_fsm_structure method should be 'out' rather than 'inout'

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:50 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Fix the direction of the parameter of ExtendedFsmService::get_fsm_structure

    The direction of fsm_structure parameter has been change to 'out' from 'inout'.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-7.docx 1.11 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Section 7.2.4.2, detail descriptions for each element of the table of hints are required

  • Key: FSMCFRFF-5
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Section 7.2.4.2, each element of the table of hints is hard to understand with out any detail description.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:45 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Explanations and examples have been added to the hint argument of ComponentObserver::update_status

    To make the usage of hint argument of ComponentObserver::update_status clearer, explanations and examples have been added to each definition of hint in Section 7.2.4.2.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-5.docx 1.11 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Section 7.2.6, PSM representations such as 'CORBA::RepositoryID' are used in the PIM

  • Key: FSMCFRFF-8
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    Platform specific representations should not used in PIM models.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:56 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    PSM representations in the PIM section have been replaced

    PSM representations in the PIM section have been replaced with PIM representations.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:
    • FSMCFRFF-8.docx 1.11 MB (application/vnd.openxmlformats-officedocument.wordprocessingml.document)

In Figure 7.1, RTC::FSM interface is used but it is not defined in the RTC spcefification

  • Key: FSMCFRFF-2
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In Figure 7.1, "an example declaration of FSM component (non-normative)" defines FsmComponent which inherits RTC::FSM as an interface.
    However, in the RTC specification there is no definition of RTC::FSM interface.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 16:58 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Replace Figure 7.1 with the Figure 5.21 of the RTC specification

    FSM4RTC does not specify any FSM component. Thus, it is relevant to use the same figure as the RTC specification.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments:

In Figure 7.2, relationship among FsmComponent, ComponentObserver, ExtendedFsmService and DataPort is unclear

  • Key: FSMCFRFF-3
  • Status: closed  
  • Source: Honda ( Makoto Sekiya)
  • Summary:

    In the Use Case diagram as Figure 7.2, unfamiliar elements such as packages and dependencies are used. These elements should be replaced with actors, use cases and boundaries to show the relationship among elements clearly.

  • Reported: FSM4RTC 1.0b1 — Mon, 23 Mar 2015 17:19 GMT
  • Disposition: Resolved — FSM4RTC 1.0
  • Disposition Summary:

    Update the use case diagram of Figure 7.2

    To make it clearer, the use case diagram of Figure 7.2 has been updated with usual elements such as boundaries and actors instead of packages.

  • Updated: Tue, 22 Dec 2015 15:06 GMT
  • Attachments: