-
Key: DDSSEC11-7
-
Status: closed
-
Source: Twin Oaks Computing, Inc. ( Mr. Clark Tucker)
-
Summary:
Most of the original list of points were addressed as part of the FTF2.
The remaining two points are copied below:
----------------------------------------------------
7.3.7 – missing section for SecuredPayload SubmessageElement
Or, [and i think this is better], replace everywhere SecuredPayload with
SecureDataBody. Then, add a section in 7.3.7 for SecureDataBody.----------------------------------------------------
7.3.6.2 RTPS Submessage: SecureSubMsg
Figure 5 does not show SecureSubMsg.
Should SecureSubMsg be removed?
Or maybe it should be used only as a 'generic' term.
SecureSubMsg is referenced many times in
"Section 8.8.10 Cryptographic Plugins encoding/decoding behavior".
Because of this, it might be good to define 'SecureSubMsg' as
the sequence [ SecurePrefix + SecureBody|SerializedSubMsg + SecurePostfix ].
Does that work?=======================================================
Original list of points is below
=======================================================----------------------------------------------------
7.3.7.4 SecureDataTag Element
Typo in second para:The UDP/IP wire representation for the SecuredPayload shall be:
Should be
The UDP/IP wire representation for the SecuredDataTag shall be:
Gerardo: Fixed in AB errata
----------------------------------------------------7.3.7.8 SecureRTPSPrefixSubMsg Submessage
Is it true that it contains SecureDataTag?
It should contain a SecureDataHeader, I think.Gerardo: Fixed in AB errata
----------------------------------------------------Mention of TransformationKeyId (section 9.5.2.5) and
CryptoTransformationKeyId (section 9.5.2.1.1) should
be CryptoTransformKeyIdGerardo: Fixed in AB errata
----------------------------------------------------9.5.2.4 DDS:Crypto:AES-GCM-GMAC SecureDataBody
Second paragraph "SecureDataTag" should be "SecureDataBody".
The IDL does not include the 'struct' typename:
@Extensibility(FINAL_EXTENSIBILITY)
{ sequence<octet> secure_data; };
struct
Should be:
@Extensibility(FINAL_EXTENSIBILITY)
struct SecureDataBody { sequence<octet> secure_data; };
Gerardo: This was already fixed by 182
----------------------------------------------------
9.5.2.5 DDS:Crypto:AES-GCM-GMAC SecureDataTagThe IDL shows receiver_mac is octet[8], but I think
it should be octet[16]. 16 bytes is consistent with the
format shown in 9.5.3.3.4.3.Gerardo: Fixed in AB errata
----------------------------------------------------
7.3.7.8 SecureRTPSPrefixSubMsg SubmessageMessage structure shows contents as SecureDataTag. Should be
SecureDataHeader.Gerardo: This was already fixed by 182
----------------------------------------------------7.3.7 – missing section for SecuredPayload SubmessageElement
Or, [and i think this is better], replace everywhere SecuredPayload with
SecureDataBody. Then, add a section in 7.3.7 for SecureDataBody.Gerardo: Too big a change for AB Errata. Push to RTF
----------------------------------------------------7.3.6.2 RTPS Submessage: SecureSubMsg
Figure 5 does not show SecureSubMsg.
Should SecureSubMsg be removed?
Or maybe it should be used only as a 'generic' term.SecureSubMsg is referenced many times in
"Section 8.8.10 Cryptographic Plugins encoding/decoding behavior".Because of this, it might be good to define 'SecureSubMsg' as
the sequence [ SecurePrefix + SecureBody|SerializedSubMsg + SecurePostfix ].
Does that work?Gerardo: Too big a change for AB Errata. Push to RTF
----------------------------------------------------
7.3.7.5 SecureBodySubMsg SubmessageMentions SecureSubMsg, but should be SecureBodySubMsg
Gerardo: Fixed in AB errata
----------------------------------------------------7.3.7.6 SecurePrefixSubMsg Submessage
Mentions SecureSubMsg, should be SecurePrefixSubMsg
Gerardo: Fixed in AB errata
----------------------------------------------------7.3.7.7 SecurePostfixSubMsg Submessage
Mentions SecureSubMsg, should be SecurePostfixSubMsg
Gerardo: Fixed in AB errata
-
Reported: DDS-SECURITY 1.0b1 — Sat, 12 Mar 2016 20:21 GMT
-
Disposition: Resolved — DDS-SECURITY 1.1
-
Disposition Summary:
Rename SecureDataHeader, SecurePayload, SecureDataTag
Rename the following submessage elements:
SecureDataHeader -> CryptoHeader
SecuredPayload -> CryptoContent
SecureDataTag -> CryptoFooter -
Updated: Tue, 19 Dec 2017 20:03 GMT
-
Attachments:
- SecureSubmessages.emf 89 kB ()
DDSSEC11 — Inconsistency in SubMessage and SubMessageElement naming throughout document
- Key: DDSSEC11-7
- OMG Task Force: DDS Security 1.1 RTF