-
Key: DDSPSMC11_-57
-
Legacy Issue Number: 18627
-
Status: open
-
Source: Leonardo S.p.A ( Simon McQueen)
-
Summary:
Compilation fixes and corrections to API documentation comments required.
Incorrect default reliability duration (infinite). Should be 100 milliseconds per table in section "7.1.3 Supported QoS" (formal 07-01-01)
Suggested resolution:
diff --git a/src/hpp/dds/core/policy/TCorePolicy.hpp b/src/hpp/dds/core/policy/TCorePolicy.hpp index 382e521..1313b32 100644 --- a/src/hpp/dds/core/policy/TCorePolicy.hpp +++ b/src/hpp/dds/core/policy/TCorePolicy.hpp @@ -47,7 +47,7 @@ namespace dds { namespace core { namespace policy { /** * Create a <code>UserData</code> instance with an empty user data. */ - TUserData() : dds::core::Value<D>(); + TUserData(); /** * Create a <code>UserData</code> instance. @@ -56,7 +56,7 @@ namespace dds { namespace core { namespace policy { */ explicit TUserData(const dds::core::ByteSeq& seq); - //@TODO Implement + /** @todo Implement this */ TUserData(const uint8_t* value_begin, const uint8_t* value_end); TUserData(const TUserData& other); @@ -102,16 +102,16 @@ namespace dds { namespace core { namespace policy { class TGroupData : public dds::core::Value<D> { public: /** - * Create a <code>GroupData<code> instance. + * Create a <code>GroupData</code> instance. */ - TGroupData() : dds::core::Value<D>(); + TGroupData(); /** - * Create a <code>GroupData<code> instance. + * Create a <code>GroupData</code> instance. * * @param seq the group data value */ - explicit TGroupData(const dds::core::ByteSeq& seq) : dds::core::Value<D>(seq); + explicit TGroupData(const dds::core::ByteSeq& seq); TGroupData(const TGroupData& other); @@ -160,7 +160,7 @@ namespace dds { namespace core { namespace policy { template <typename D> class TTopicData : public dds::core::Value<D> { public: - TTopicData() : dds::core::Value<D>(); + TTopicData(); explicit TTopicData(const dds::core::ByteSeq& seq); @@ -219,7 +219,7 @@ namespace dds { namespace core { namespace policy { template <typename D> class TEntityFactory : public dds::core::Value<D> { public: - TEntityFactory() :dds::core::Value<D>(true); + TEntityFactory(); explicit TEntityFactory(bool the_auto_enable); TEntityFactory(const TEntityFactory& other); @@ -255,7 +255,7 @@ namespace dds { namespace core { namespace policy { public: explicit TTransportPriority(int32_t prio); - TTransportPriority() : dds::core::Value<D>(0); + TTransportPriority(); TTransportPriority(const TTransportPriority& other); @@ -554,7 +554,7 @@ namespace dds { namespace core { namespace policy { const dds::core::Duration max_blocking_time() const; public: - static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration::infinite()); + static TReliability Reliable(const dds::core::Duration& d = dds::core::Duration(0, 100000000)); static TReliability BestEffort(); };
-
Reported: DDS-PSM-Cxx 1.0b2 — Tue, 9 Apr 2013 04:00 GMT
-
Updated: Sun, 30 Sep 2018 23:30 GMT
DDSPSMC11_ — API correction required to src/hpp/dds/core/policy/TCorePolicy.hpp
- Key: DDSPSMC11_-57
- OMG Task Force: DDS-PSM-Cxx v1.1 RTF