-
Key: DDSPSMC11_-56
-
Legacy Issue Number: 18643
-
Status: open
-
Source: Leonardo S.p.A ( Simon McQueen)
-
Summary:
Vestigial implementation code needs removing to be consistent with other No-op listener declarations.
Missing headers required to fix compilation.
Suggested resolution:
diff --git a/src/hpp/dds/sub/AnyDataReaderListener.hpp b/src/hpp/dds/sub/AnyDataReaderListener.hpp index 4646bfd..aabd71a 100644 --- a/src/hpp/dds/sub/AnyDataReaderListener.hpp +++ b/src/hpp/dds/sub/AnyDataReaderListener.hpp @@ -19,6 +19,8 @@ * limitations under the License. */ +#include <dds/core/refmacros.hpp> +#include <dds/core/status/Status.hpp> namespace dds { namespace sub { @@ -59,37 +61,36 @@ namespace dds { namespace sub { const dds::core::status::SampleLostStatus& status) = 0; }; - class NoOpAnyDataReaderListener : public virtual AnyDataReaderListener { public: - virtual ~NoOpAnyDataReaderListener() { } + virtual ~NoOpAnyDataReaderListener(); public: virtual void on_requested_deadline_missed( AnyDataReader& the_reader, - const dds::core::status::RequestedDeadlineMissedStatus& status) { } + const dds::core::status::RequestedDeadlineMissedStatus& status); virtual void on_requested_incompatible_qos( AnyDataReader& the_reader, - const dds::core::status::RequestedIncompatibleQosStatus& status) { } + const dds::core::status::RequestedIncompatibleQosStatus& status); virtual void on_sample_rejected( AnyDataReader& the_reader, - const dds::core::status::SampleRejectedStatus& status) { } + const dds::core::status::SampleRejectedStatus& status); virtual void on_liveliness_changed( AnyDataReader& the_reader, - const dds::core::status::LivelinessChangedStatus& status) { } + const dds::core::status::LivelinessChangedStatus& status); - virtual void on_data_available(AnyDataReader& the_reader) { } + virtual void on_data_available(AnyDataReader& the_reader); virtual void on_subscription_matched( AnyDataReader& the_reader, - const dds::core::status::SubscriptionMatchedStatus& status) { } + const dds::core::status::SubscriptionMatchedStatus& status); virtual void on_sample_lost( AnyDataReader& the_reader, - const dds::core::status::SampleLostStatus& status) { } + const dds::core::status::SampleLostStatus& status); }; } }
-
Reported: DDS-PSM-Cxx 1.0b2 — Tue, 9 Apr 2013 04:00 GMT
-
Updated: Sun, 30 Sep 2018 23:30 GMT
DDSPSMC11_ — API correction required to src/hpp/dds/sub/AnyDataReaderListener.hpp
- Key: DDSPSMC11_-56
- OMG Task Force: DDS-PSM-Cxx v1.1 RTF