Key: DMN14-74

Status: closed

Source: Red Hat ( Matteo Mortari)

Summary:

The DMN example files provided with DMNv1.3 have a few problems which need to be corrected, one issue specifically is preventing from being a correct DMN format, possibly inadvertently a result of the tinkering which happened before final release:

Chapter11 second example files are missing default xlmns
Loan Info.dmn: typo in Monthly HOA/Condo Fee
Loan Info.dmn: typo in Quallifying Monthly Payment
Recommended Loan Products.dmn: itemDefinition of "tLoanProduct" component Product Name allowedValues is not consistent with itemDefinition "tProductName"
Chapter11 first example typo in "MartitalStatus"

Proposal

The fix will require an update in the Figure 11.16 in the DMN specification document, but mostly a code change in the DMN model files.

Figure 11.16: Application risk score decision logic will need to be updated. An updated file will be attached at proposal creation time
A code change GitHub pull request will be raised to correct for the above, as below patch. Myself (Matteo Mortari) will raise it directly against the required GitHub repo.

diff --git a/examples/Chapter 11 Example 1 Originations/Chapter 11 Example.dmn b/examples/Chapter 11 Example 1 Originations/Chapter 11 Example.dmn
index deaf94a..f5a2b76 100644
--- a/examples/Chapter 11 Example 1 Originations/Chapter 11 Example.dmn	
+++ b/examples/Chapter 11 Example 1 Originations/Chapter 11 Example.dmn	
@@ -36,7 +36,7 @@
         <semantic:itemComponent isCollection="false" name="Age" id="_df3aab6f-1610-41fa-a407-09678a89d6da">
             <semantic:typeRef>number</semantic:typeRef>
         </semantic:itemComponent>
-        <semantic:itemComponent isCollection="false" name="MartitalStatus" id="_d39ad810-7781-4ffb-9644-de51d1ca7f7a">
+        <semantic:itemComponent isCollection="false" name="MaritalStatus" id="_d39ad810-7781-4ffb-9644-de51d1ca7f7a">
             <semantic:typeRef>string</semantic:typeRef>
             <semantic:allowedValues triso:constraintsType="enumeration">
                 <semantic:text>"S","M"</semantic:text>
@@ -1454,7 +1454,7 @@ else false</semantic:text>
             <semantic:binding>
                 <semantic:parameter id="_259966f2-bf40-4139-b587-6c9b989f1aa0" name="Marital Status"/>
                 <semantic:literalExpression id="_610941db-8c4e-483c-9d75-789b3d5c2333">
-                    <semantic:text>Applicant data.MartitalStatus</semantic:text>
+                    <semantic:text>Applicant data.MaritalStatus</semantic:text>
                 </semantic:literalExpression>
             </semantic:binding>
             <semantic:binding>
diff --git a/examples/Chapter 11 Example 2 Ranked Loan Products/Loan info.dmn b/examples/Chapter 11 Example 2 Ranked Loan Products/Loan info.dmn
index 64ae127..e9bd0c4 100644
--- a/examples/Chapter 11 Example 2 Ranked Loan Products/Loan info.dmn	
+++ b/examples/Chapter 11 Example 2 Ranked Loan Products/Loan info.dmn	
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<semantic:definitions xmlns:semantic="https://www.omg.org/spec/DMN/20191111/MODEL/" id="_5c8b9296-96cf-4898-bba5-3a2d21d34eed" name="Loan info" namespace="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed" exporter="DMN Modeler" exporterVersion="6.2.2.3">
+<semantic:definitions id="_5c8b9296-96cf-4898-bba5-3a2d21d34eed" name="Loan info" namespace="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed" exporter="DMN Modeler" exporterVersion="6.2.2.3" xmlns:semantic="https://www.omg.org/spec/DMN/20191111/MODEL/" xmlns="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed">
 	<semantic:itemDefinition name="tBorrower" label="tBorrower">
 		<semantic:itemComponent id="_b7dcc14d-510d-4628-a510-ca774208e501" name="Full Name">
 			<semantic:typeRef>string</semantic:typeRef>
@@ -125,7 +125,7 @@
 		<semantic:itemComponent id="_aa55fa1a-3e82-4439-b422-21921c6a64b0" name="Monthly Insurance Payment">
 			<semantic:typeRef>number</semantic:typeRef>
 		</semantic:itemComponent>
-		<semantic:itemComponent id="_77f3b202-47ba-432b-9ada-e81700db445f" name="Monthly HOA/Condo Fee">
+		<semantic:itemComponent id="_77f3b202-47ba-432b-9ada-e81700db445f" name="Monthly HOA Condo Fee">
 			<semantic:typeRef>number</semantic:typeRef>
 		</semantic:itemComponent>
 	</semantic:itemDefinition>
@@ -204,7 +204,7 @@
 		<semantic:itemComponent id="_cd96db58-d312-41dc-a3e4-6fa93766b49d" name="Initial Monthly Payment" isCollection="false">
 			<semantic:typeRef>number</semantic:typeRef>
 		</semantic:itemComponent>
-		<semantic:itemComponent id="_c05792fd-417f-4662-b6b8-7cf708c26976" name="Quallifying Monthly Payment" isCollection="false">
+		<semantic:itemComponent id="_c05792fd-417f-4662-b6b8-7cf708c26976" name="Qualifying Monthly Payment" isCollection="false">
 			<semantic:typeRef>number</semantic:typeRef>
 		</semantic:itemComponent>
 		<semantic:itemComponent id="_30babadc-60b5-4879-b233-410b43349ef4" name="Points Amount">
diff --git a/examples/Chapter 11 Example 2 Ranked Loan Products/Recommended Loan Products.dmn b/examples/Chapter 11 Example 2 Ranked Loan Products/Recommended Loan Products.dmn
index 3c1983e..8a6e355 100644
--- a/examples/Chapter 11 Example 2 Ranked Loan Products/Recommended Loan Products.dmn	
+++ b/examples/Chapter 11 Example 2 Ranked Loan Products/Recommended Loan Products.dmn	
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<semantic:definitions xmlns:semantic="https://www.omg.org/spec/DMN/20191111/MODEL/" xmlns:tc="http://www.omg.org/spec/DMN/20160719/testcase" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"   id="_736fa164-03d8-429f-8318-4913a548c3a6" name="Recommended Loan Products" namespace="http://www.trisotech.com/definitions/_736fa164-03d8-429f-8318-4913a548c3a6" exporter="DMN Modeler" exporterVersion="6.2.3" xmlns:include1="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed">
+<semantic:definitions id="_736fa164-03d8-429f-8318-4913a548c3a6" name="Recommended Loan Products" namespace="http://www.trisotech.com/definitions/_736fa164-03d8-429f-8318-4913a548c3a6" exporter="DMN Modeler" exporterVersion="6.2.3" xmlns:semantic="https://www.omg.org/spec/DMN/20191111/MODEL/" xmlns:tc="http://www.omg.org/spec/DMN/20160719/testcase" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:include1="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed" xmlns="http://www.trisotech.com/definitions/_736fa164-03d8-429f-8318-4913a548c3a6">
 	<semantic:import namespace="http://www.trisotech.com/definitions/_5c8b9296-96cf-4898-bba5-3a2d21d34eed" name="Services" importType="https://www.omg.org/spec/DMN/20191111/MODEL/"/>
 	<semantic:itemDefinition name="tBorrower" label="tBorrower">
 		<semantic:itemComponent id="_b7dcc14d-510d-4628-a510-ca774208e501" name="Full Name">
@@ -152,7 +152,7 @@
 		<semantic:itemComponent id="_68f6a641-5e2d-4b1b-9f2b-41f933976dee" name="Product Name" isCollection="false">
 			<semantic:typeRef>tProductName</semantic:typeRef>
 			<semantic:allowedValues>
-				<semantic:text>"Fixed30-NoPointsOrFees","Fixed30-Standard","Fixed30-LowestRate","Fixed15-NoPointsOrFees","Fixed15-Standard"</semantic:text>
+				<semantic:text>"Fixed30-NoPoints","Fixed30-Standard","Fixed30-LowestRate","Fixed15-NoPoints","Fixed15-Standard","ARM5/1-NoPoints","ARM5/1-Standard"</semantic:text>
 			</semantic:allowedValues>
 		</semantic:itemComponent>
 		<semantic:itemComponent id="_39c5300a-339c-4bde-8dfc-17e5d3f6f535" name="Type" isCollection="false">

Reported: DMN 1.2 — Tue, 7 Jan 2020 10:30 GMT

Disposition: Resolved — DMN 1.4

Disposition Summary:

Fix typos in example figure and XML files

The fix will require an update in the Figure 11.16 in the DMN specification document, but mostly a code change in the DMN model files.

Figure 11.16: Application risk score decision logic will need to be updated
Code change GitHub pull request: https://github.com/omg-dmn-taskforce/omg-dmn-spec/pull/6

Updated: Thu, 31 Mar 2022 19:30 GMT

Attachments:

correct.png 26 kB (image/png)
wrong.png 37 kB (image/png)