XTCE12 — Time/Encoding@scale,@offset terminology vs DynamicValue/LinearAdjust

Description Kevin Rice 2008-05-01 21:19:28 BST
These two items use a y=mx+b style adjuster to change the value given. The
terminology should be aligned.

One implements it using attributes the other a seperate element, possible these
should be aligned as well.

FINALLY the default SLOPE (i.e. 'm') is 0 in one which is wrong – adding an
empty LinearAdjust will result in a ZERO-ing of the retrieve dynamic value – a
mistake.

Propose to make elements with slope intercept make more sense

For the case of the LinearAdjustmentType complexType, remove the default values from the slope attribute. The LinearAdjustment element itself is optional, so when present, it should have some substantive content instead of being an empty element. In addition, the data type of the attributes should be double to prevent code generators from making specialty types, such as "BigDecimal".

Existing definition:

<complexType name="LinearAdjustmentType">
<annotation>
<documentation xml:lang="en">A slope and intercept may be applied to scale or shift the value of the parameter in the dynamic value</documentation>
</annotation>
<attribute name="slope" type="decimal" default="0"/>
<attribute name="intercept" type="decimal" default="0"/>
</complexType>

Change attribute for @slope from:

<attribute name="slope" type="decimal" default="0"/>

To

<attribute name="slope" type="double"/>

Change attribute for @intercept from:

<attribute name="intercept" type="decimal" default="0"/>

To:

<attribute name="intercept" type="double" default="0"/>