HAL4RT 1.0 FTF Avatar
  1. OMG Issue

HAL4RT — Syntax errors in HAL4RT_Device.h (robotics/15-11-05)

Open Closed All
  • Key: HAL4RT-9
  • Status: open  
  • Source: AIST ( Dr. Noriaki Ando)
  • Summary:

    Since HAL4RT_Device.h (robotics/15-11-05) includes some syntax errors, it cannot be compiled.

    1. To use int32_t #include <stdint.h> directive necessary. (C99)
    2.Syntax errors without sentence termination character ";" in ACTUATOR and SENSOR structure declarations.
    3. Invalid function pointers declarations in SENSOR structure.
    4. Invalid #endif syntax.

    HAL4RT_Device.h.patch
    --- org/HAL4RT_Device.h 2016-03-15 03:11:51.496000000 +0900
+++ mod/HAL4RT_Device.h 2016-03-15 03:14:42.412000000 +0900
@@ -1,6 +1,7 @@
 #ifndef HAL4RT_DEVICE_H
 #define HAL4RT_DEVICE_H

+#include <stdint.h>

 typedef struct HALComponent {
   char ComponentName[32];
@@ -13,7 +14,7 @@

 typedef struct Actuator {
   uint32_t ActuatorKindId;
-} ACTUATOR
+} ACTUATOR;


 typedef struct Sensor {
@@ -21,13 +22,13 @@
   int32_t ValueOfMeasurement[32];
   int32_t ScaleFactor[32];
   int32_t Origin[32];
-  int32_t GetSensorKind();
-  int32_t GetValueOfMeasurement();
-  int32_t SetUintOfMeasurement();
-  int32_t GetUnitOfMeasurement();
-  int32_t SetScaleFactor();
-  int32_t SetOrigin();
-} SENSOR
+  int32_t (*GetSensorKind)();
+  int32_t (*GetValueOfMeasurement)();
+  int32_t (*SetUintOfMeasurement)();
+  int32_t (*GetUnitOfMeasurement)();
+  int32_t (*SetScaleFactor)();
+  int32_t (*SetOrigin)();
+} SENSOR;


-#endif HAL4RT_DEVICE_H
+#endif /* HAL4RT_DEVICE_H */
  • Reported: HAL4RT 1.0b1 — Mon, 14 Mar 2016 18:24 GMT
  • Updated: Mon, 6 Nov 2017 12:34 GMT