FUML — CompoundValue::equals does not conform to Annex A conventions

Specification: Semantics of a Foundation Subset for Executable UML Models, FTF – Beta 1 (ptc/08-11-03)
Section: 8.3.2.2.2 CompoundValue

Summary:

The CompoundValue::equals operation has more than one return statement and uses the “&&”. These are not allowed by the conventions of Annex A.

Proposed Resolution:

Replace the body of the equals operation with:

boolean isEqual = otherValue instanceof CompoundValue;

if (isEqual) {

CompoundValue otherCompoundValue = (CompoundValue)otherValue;

// Debug.println("[equals] " + this.featureValues.size() + " feature(s).");

isEqual = super.equals(otherValue) & otherCompoundValue.featureValues.size() == this.featureValues.size();

int i = 1;

while (isEqual & i <= this.featureValues.size()) {

FeatureValue thisFeatureValue = this.featureValues.getValue(i-1);

boolean matched = false;

int j = 1;

while (!matched & j <= otherCompoundValue.featureValues.size()) {

FeatureValue otherFeatureValue = otherCompoundValue.featureValues.getValue(j-1);

if (thisFeatureValue.feature == otherFeatureValue.feature)

j = j + 1;

}

isEqual = matched;

i = i + 1;

}

}

return isEqual;

Change the code as proposed